test(ci): stabilize Windows suites after Studio cutover#2320
Merged
Conversation
f3e6848 to
650b10d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root causes
Two consecutive
mainWindows runs timed out in the firstcheckBrowser.test.tscase (29227777037, 29220733386). The test mocked@hyperframes/core/compiler, but production reaches bundling throughbundleWithLocalizedFonts, so the first case cold-loaded the unrelated producer/font graph under the full Windows monorepo workload and exhausted Vitest's 20s ceiling.After the Studio/Ular cutover merged, both Linux and Windows then consistently failed two
useTimelinePlayerassertions. #2291 intentionally narrowed downgrade preservation to enriched sub-composition children so undoing a split can remove a top-level clone instead of leaving a ghost clip; the old tests still expected every missing top-level element to be preserved.Fix
bundleWithLocalizedFontsboundary and assert the project directory crosses that seam. The real helper remains covered by its own integration test.No production timeout or behavior was loosened.
Verification
bun run build✅checkBrowser.test.tsruns: 10/10 passed, 1.79–2.35s wall time ✅